add delay and retry to mAIner topup backend call#149
Open
lopezi wants to merge 2 commits intoreleases/vicifrom
Open
add delay and retry to mAIner topup backend call#149lopezi wants to merge 2 commits intoreleases/vicifrom
lopezi wants to merge 2 commits intoreleases/vicifrom
Conversation
Adds a 3-second delay between successful token transfer and backend topup call to ensure the ledger transaction is queryable. Also adds one automatic retry with a 2-second wait if the initial backend call fails.
patnorris
reviewed
Jan 21, 2026
| try { | ||
| const result = await makeTopupCall(); | ||
| return result; | ||
| } catch (firstError) { |
Contributor
There was a problem hiding this comment.
if the backend call doesn't return properly (OK but Err), we need to retry as well
patnorris
reviewed
Jan 21, 2026
| backendPromise = $store.gameStateCanisterActor.topUpCyclesForMainerAgent(topUpInput); | ||
|
|
||
| try { | ||
| const result = await makeTopupCall(); |
Contributor
There was a problem hiding this comment.
before we didn't await the backend response ("backendPromise") to avoid keeping the user on the screen too long. As we now await it, the user has to wait on the topup modal. Is there a good way to reconcile this with the retry?
Collaborator
Author
There was a problem hiding this comment.
but it still closes the modal before the transaction completes. is that what you are considering here?
Contributor
There was a problem hiding this comment.
cool, then this sounds good
The retry logic now triggers not only on exceptions but also when the backend call returns successfully but with an Err result variant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a 3-second delay between successful token transfer and backend topup call to ensure the ledger transaction is queryable. Also adds one automatic retry with a 2-second wait if the initial backend call fails.